Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factions Rework (part 1) #8225

Conversation

blackcrystall
Copy link
Contributor

@blackcrystall blackcrystall commented Jan 24, 2025

Erm... another random no reason rework from blackcrystalic? arent it based? Skill issue
Okay, sorry, next time I'll go mess with balance and coding useles things... sorry.

About the pull request

Mostly it's rewriting hive datum to faction datum and new additions like modules to faction datum

For now this PR just to get help and some ideas for imporvement (WIP), hard part of it done already, but there need to be testing and improvements on some ground... because I don't want them to be in part 2, this part dedicated for another mess around.

Anyway, for part two is faction interactions, auto balance, and some ground for gamemode from road map, also some mess around with interfaces and etc
Big thanks to my source repository that I lovely coded for 5 years of adding every shit idea I got... it's like a gift box, you can take from it a lot of stuff

Right now what we got to do
Add every faction to datum
Add to turrets code side IFF modes and way for giving it more faction iff signals
More interesting way of how IFF system work, or we want it to be majestic creature of unknown power? Id cards iff is funny, but nah, we got iff tags, for now nothing interesting with it
Take more descriptions from sources for factions?? and fill them, plus port faction ui with info about it and current factions relations status and alliance info

Explain why it's good for the game

  1. Easy multi faction roles handling
  2. Improvements for future factions interactions on level upper (code side for RP realization)
  3. A lot space for future improvement for factions in general, starting from simply HVH event, up to some roadmap like new gamemodes with auto balance (autobalancer will be lovely put in part 2)
  4. I tired, maybe latter I find out what to tell about it more, from non code perspective of just rewriting 305 filles and 4k lines

Changelog

🆑 BlackCrystalic
refactor: Factions
/:cl:

@cmss13-ci cmss13-ci bot added UI deletes nanoui/html Refactor Make the code harder to read labels Jan 24, 2025
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jan 24, 2025
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@blackcrystall blackcrystall marked this pull request as draft January 24, 2025 11:56
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jan 24, 2025
@cmss13-ci cmss13-ci bot added the Mapping did you remember to save in tgm format? label Jan 24, 2025
@cmss13-ci cmss13-ci bot added the Sprites Remove the soul from the game. label Jan 25, 2025
@cuberound
Copy link
Contributor

https://github.com/cmss13-devs/cmss13/pull/8254/files this might help with part 2. at least cleans up the code of copypaste hardcoded stuff. if you figure out autobalance that is good but kinda complicated to do right

@cuberound
Copy link
Contributor

I am 80% sure sentryguns have list of IFF not just one

@blackcrystall
Copy link
Contributor Author

blackcrystall commented Jan 27, 2025

This will be added later, for now just simply modes between all ally signals and only strict for faction

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jan 27, 2025
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jan 28, 2025
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jan 28, 2025
@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jan 28, 2025
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jan 29, 2025
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jan 29, 2025
@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jan 30, 2025
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@cm13-github
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@cm13-github cm13-github removed the Merge Conflict PR can't be merged because it touched too much code label Jan 30, 2025
@cm13-github cm13-github added the Merge Conflict PR can't be merged because it touched too much code label Jan 31, 2025
@cm13-github
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@blackcrystall
Copy link
Contributor Author

Okay, nevermind... There no point in doing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mapping did you remember to save in tgm format? Merge Conflict PR can't be merged because it touched too much code Refactor Make the code harder to read Sprites Remove the soul from the game. UI deletes nanoui/html
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants